Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[network] Really skip excluded_interfaces #1260

Merged
merged 1 commit into from
Jan 5, 2015

Conversation

mrcljx
Copy link
Contributor

@mrcljx mrcljx commented Dec 23, 2014

Not sure if the comment is still relevant.

At least the current feature is broken and the code guarantees it stays broken.

@LeoCavaille
Copy link
Member

@sirlantis thanks a lot for your contribution!
We'll review it and test it, it should be part of the soon to be released 5.2.

@LeoCavaille LeoCavaille added this to the 5.2.0 milestone Dec 29, 2014
@LeoCavaille LeoCavaille changed the title Really skip excluded_interfaces [network] Really skip excluded_interfaces Dec 29, 2014
@mrcljx
Copy link
Contributor Author

mrcljx commented Dec 30, 2014

I just noticed that I didn't verify the change correctly (I didn't remove excluded_interface_re: lo.*). So I removed that setting and applied the patch to a machine where we noticed this issue the first time. The graph stays the same:

screen shot 2014-12-30 at 18 11 29

So at least from my end I can confirm that this patch is effective. Hope it works for you as well.

A happy new year to you all.

@LeoCavaille
Copy link
Member

@sirlantis happy new year to you too!

LeoCavaille added a commit that referenced this pull request Jan 5, 2015
[network] Really skip excluded_interfaces
@LeoCavaille LeoCavaille merged commit e18cb49 into DataDog:master Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants